-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy ahb without CPU read mask v2 #2042
base: dev
Are you sure you want to change the base?
Conversation
CI gfxreconstruct build queued with queue ID 379392. |
CI gfxreconstruct build # 6145 running. |
CI gfxreconstruct build # 6145 failed. |
57cdaa5
to
f2b33a2
Compare
CI gfxreconstruct build queued with queue ID 380043. |
CI gfxreconstruct build # 6153 running. |
f2b33a2
to
37a0180
Compare
CI gfxreconstruct build queued with queue ID 380084. |
CI gfxreconstruct build # 6154 running. |
37a0180
to
dd55f2f
Compare
CI gfxreconstruct build queued with queue ID 380106. |
CI gfxreconstruct build # 6155 running. |
CI gfxreconstruct build # 6155 failed. |
dd55f2f
to
092ddf7
Compare
CI gfxreconstruct build queued with queue ID 380217. |
CI gfxreconstruct build # 6157 running. |
CI gfxreconstruct build # 6157 failed. |
092ddf7
to
2df7a4c
Compare
CI gfxreconstruct build queued with queue ID 380436. |
CI gfxreconstruct build # 6158 running. |
2df7a4c
to
221bf2e
Compare
CI gfxreconstruct build queued with queue ID 380468. |
CI gfxreconstruct build # 6159 running. |
CI gfxreconstruct build # 6159 failed. |
CI gfxreconstruct build queued with queue ID 381311. |
CI gfxreconstruct build # 6182 running. |
CI gfxreconstruct build # 6182 failed. |
CI gfxreconstruct build # 6210 failed. |
Device utilities check for features and properties using vkGetPhysicalDeviceProperties2 which is available from Vulkan version 1.1 or its KHR version by enabling the corresponding extension. Make sure to enable this extension when API version is < 1.1 and only call vkGetPhysicalDeviceProperties2KHR if it was available and enabled.
Non-CPU readable AHB memory can not be copied, but it can be sampled with a Ycbcr sampler. If available, enable the corresponding feature is enabled for capture.
6bc3218
to
d77f380
Compare
CI gfxreconstruct build queued with queue ID 384857. |
CI gfxreconstruct build queued with queue ID 384860. |
CI gfxreconstruct build # 6239 running. |
CI gfxreconstruct build # 6239 failed. |
Import non-CPU readable Android Hardware Buffers with a VkImage. Use a Ycbcr conversion sampler to get data from external unknown format to RGBA8. Finally, read the data from GPU to host for a FillImageMemory command.
Importing external memory with external format is not supported at replay time. The capture stored data in RGBA8_UNORM. The content of the Android Hardware Buffer is restored with a Vulkan image which imports the AHB memory, then it's filled reusing functionalities of the resource initializer. Finally, both image views and samplers are patched to remove any reference to Android hardware buffers and external memory formats.
Instead of modifying the sampler, patch the conversion so that it works with RGBA8 formatted data.
560d720
to
127f835
Compare
CI gfxreconstruct build queued with queue ID 385951. |
CI gfxreconstruct build # 6244 running. |
CI gfxreconstruct build # 6244 failed. |
Do not query memory requirements before binding external memory to image.
VUID-VkMemoryDedicatedAllocateInfo-image-02964 If image is not VK_NULL_HANDLE and the memory is not an imported AHB or an imported QNX Screen buffer, VkMemoryAllocateInfo::allocationSize must equal the VkMemoryRequirements::size of the image.
VUID-VkMemoryDedicatedAllocateInfo-image-02964 If image is not VK_NULL_HANDLE and the memory is not an imported AHB or an imported QNX Screen buffer, VkMemoryAllocateInfo::allocationSize must equal the VkMemoryRequirements::size of the image.
If memory is importing an Android Hardware Buffer, its allocation size should be equal to the AHB properties allocation size.
Do not write the state of image memory backed by an AHB as the AHB has already been processed. At replay time the content of the image will clearly correspond to the content of the AHB.
127f835
to
bbd750e
Compare
CI gfxreconstruct build queued with queue ID 386143. |
CI gfxreconstruct build # 6247 running. |
CI gfxreconstruct build # 6247 failed. |
This is built on top of Ziga's #1812
Key changes: